Bike shorts fall into two distinct types, Lycra body hugging race shorts or the baggy beach-bum-mountain biker style. Both are comfortable, but its unlikely you'll see one group wearing the others style of shorts. All cycling shorts must have a comfortable seat; jeans are probably the worst because of the seam down the middle.
Comfortable Cycling Shorts
First the Lycra race shorts, they used to be woollen, great until it rained then they were baggy and uncomfortable and when they stretched it was possible that they would flap in the wind, very un-cool!
Then tight fitting Lycra was invented, not the warmest, but very comfortable. Any colour with team sponsors names printed on them, anything is possible.
You can get shorts, but bib-shorts are better, these have built-in braces to keep them up and are much more comfortable.
Lycra shorts also have an elastic strip around the legs to keep the shorts from riding up. All shorts need padding in the seat, this used to be chamois, now it's made from synthetic material and is a must for serious, comfortable cycling.
Baggy mountain bike shorts would fit in down at the beach in California with the surfers, except for the built in padding in the seat.
Camouflage colouring or plane, but never too bright, the baggier the better, with pockets on the front, back, sides and down the legs. You can cheat by wearing any baggy shorts with Lycra shorts underneath, this is a trick down hillers use, so they look cool at the same time as being comfortable.
How to submit your Cycling Question?
Cycle Training Mistakes